Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metadata to hidden folder and update references #3627

Merged
merged 3 commits into from
Sep 28, 2016

Conversation

piotr-cz
Copy link

Description

Move metadata to hidden folder and update references

Specific Changes proposed

This is an update to #3117, which moves files

  • CONTRIBUTING.md
  • ISSUE_TEMPLATE.md
  • PULL_REQUEST_TEMPLATE.md

to own .github folder and fixes references in markdown files.

Reference: GitHub help > Helping people contribute to your project

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Sep 20, 2016

Is there a specific reason why having it in the .github folder be better? I think I would prefer to keep them in the root of the project.

@gkatsev
Copy link
Member

gkatsev commented Sep 20, 2016

Thinking about this some more and talking with @brandonocasey, I think this would be good if we keep CONTRIBUTING.md in the root of the project but move the templates into the .github folder. CONTRIBUTING.md is/should be more than just a link that github links to at the top of issues.

@piotr-cz
Copy link
Author

The reason is to move files that don't have to be in the root repo folder to clean it up.
I'll update PR to keep the CONTRIBUTING.md file where it is now.

@gkatsev
Copy link
Member

gkatsev commented Sep 22, 2016

Tests are failing for a separate reason.

@gkatsev gkatsev added confirmed documentation patch This PR can be added to a patch release. labels Sep 27, 2016
@gkatsev gkatsev added this to the 5.12 milestone Sep 27, 2016
@gkatsev gkatsev merged commit 86f0830 into videojs:master Sep 28, 2016
@piotr-cz piotr-cz deleted the hotfix/move-metadata branch September 29, 2016 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed documentation patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants