Changed Audio Track button title to 'Audio Track' and modified en.json #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarabander
changed the title
jbarabander
changed the title
|
LGTM |
gkatsev
added
patch
|
LGTM |
misteroneill
added
confirmed
and removed
needs: LGTM
gkatsev
pushed a commit
to gkatsev/video.js
that referenced
this pull request
Aug 25, 2016
|
Merged to stable. Thanks! |
|
@gkatsev: Awesome!!! Thanks so much for all your help and encouragement! |
|
@jbarabander happy to help. Thanks for your effort as well! |
helenjer
pushed a commit
to helenjer/video.js
that referenced
this pull request
Sep 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per discussion on #3565 I changed the audio track title to be 'Audio Track' instead of just 'Audio'
Additionally I updated the en.json.
Specific Changes proposed
Modified en.json to have an entry for 'Audio Track'.
Modified the AudioTrackButton components controlText_ to be 'Audio Track'
Requirements Checklist