Prevent coveralls from running locally #3449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bash condition that previously existed in package.json was not working properly in all environments. Additionally, it would fail on Windows. This moves that condition to JavaScript, where it now works reliably.
| @@ -14,7 +14,7 @@ | |||
| "homepage": "http://videojs.com", | |||
| "author": "Steve Heffernan", | |||
| "scripts": { | |||
| "test": "grunt test && if [ '$TRAVIS' ]; then grunt coveralls; fi;" | |||
There was a problem hiding this comment.
you could also just double quote and escape travis here like grunt test && if [ \"$TRAVIS\" ]; then grunt coveralls; fi;" but if were going for windows build compatibility then grunt is he better way. LGTM other than that consideration
There was a problem hiding this comment.
Yeah, we may as well and try to make it work on windows.
There was a problem hiding this comment.
The fact that using " instead of ' would fix it suggests to me that sticking to JS instead of Bash is the way to go regardless of Windows support. 😄
There was a problem hiding this comment.
yeah bash is a fickle beast
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bash condition that previously existed in
package.jsonto check for theTRAVISenv var was not working properly for everyone, causinggrunt coverallsto run (and fail) locally.Additionally, it would fail on Windows, since it was bash.
Specific Changes proposed
This moves that condition checking for the
TRAVISenv var to JavaScript, where it now works reliably.Requirements Checklist