Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update duration and remaining time displays on durationchange #3349

Closed
wants to merge 1 commit into from
Closed

Update duration and remaining time displays on durationchange #3349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/js/control-bar/time-controls/duration-display.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,7 @@ class DurationDisplay extends Component {
constructor(player, options){
super(player, options);

// this might need to be changed to 'durationchange' instead of 'timeupdate' eventually,
// however the durationchange event fires before this.player_.duration() is set,
// so the value cannot be written out using this method.
// Once the order of durationchange and this.player_.duration() being set is figured out,
// this can be updated.
this.on(player, 'timeupdate', this.updateContent);
this.on(player, 'loadedmetadata', this.updateContent);
this.on(player, 'durationchange', this.updateContent);
}

/**
Expand Down
1 change: 1 addition & 0 deletions src/js/control-bar/time-controls/remaining-time-display.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class RemainingTimeDisplay extends Component {
super(player, options);

this.on(player, 'timeupdate', this.updateContent);
this.on(player, 'durationchange', this.updateContent);
}

/**
Expand Down