update videojs-font #2973
Closed
update videojs-font #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
|
Actually, I need to add the wrapcodepoints task here as well :/ |
|
LGTM, round 2 |
The regular exported sass files will keep using the normal sass files but users can use the new endpoint of `vjs.scss` which will use the codepoint-fixed sass. They'll also need to manually wrap the codepoints on their generated css file after the fact.
|
Ok, so, I updated this PR based on videojs/font#12 Generate css using the codepoint-fixed sass files The regular exported sass files will keep using the normal sass files |
|
The reason tests are failing is because it depends on videojs/font#12 to be merged and released. |
|
LGTM, third time's a charm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.