Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer the implementation of select functions in the tech to source handlers if they provide them #2760

Closed
wants to merge 2 commits into from

Conversation

imbcmdth
Copy link
Member

I wrote this to allow us to generically add "deferrable" functions in the tech. Right now we only need two but we could extend that later.

@pam
Copy link

pam commented Oct 29, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 4b67a05
Build details: https://travis-ci.org/pam/video.js/builds/88241048

(Please note that this is a fully automated comment.)

@pam
Copy link

pam commented Oct 30, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: b7b0c12
Build details: https://travis-ci.org/pam/video.js/builds/88397726

(Please note that this is a fully automated comment.)

@gkatsev
Copy link
Member

gkatsev commented Oct 30, 2015

So, this basically just makes the seekable and duration functions into a generic function that delegates to the source handler?

@imbcmdth
Copy link
Member Author

Yes. Seekable was already had a delegate but I felt that making it so that delegates can be added easily without replicating code was worth the effort.

@gkatsev
Copy link
Member

gkatsev commented Oct 30, 2015

LGTM

@gkatsev gkatsev mentioned this pull request Oct 30, 2015
18 tasks
@gkatsev
Copy link
Member

gkatsev commented Oct 30, 2015

Also, yay, travis is finally reporting back again

@gkatsev gkatsev closed this in 0b32893 Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants