Removed the passing of playerOptions to plugins #2532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because it caused an error, and it actually creates an inconsistent plugin init process, when considering plugins that are initialized outside of the player init. fixes videojs#2510
| @@ -157,7 +157,6 @@ class Player extends Component { | |||
| let plugins = options.plugins; | |||
|
|
|||
| Object.getOwnPropertyNames(plugins).forEach(function(name){ | |||
| plugins[name].playerOptions = playerOptionsCopy; | |||
There was a problem hiding this comment.
This is the only interesting change.
|
Sounds good to me. |
|
lgtm as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because it caused an error, and it actually creates an inconsistent
plugin init process, when considering plugins that are initialized
outside of the player init.
fixes #2510
This was originally introduced in #2229, by my request. Seemed like a good idea at the time but unless anyone thinks it would be very valuable I think we should remove it for the consistency reason mentioned.
Also changed the Plugin var name in tests for clarity, before deciding just to remove the feature.