Fire "seeking" from the Flash tech #2372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
There's an error in travis, though. |
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: d786673 (Please note that this is a fully automated comment.) |
|
The mockFlash object needs Otherwise lgtm. |
|
This one is still a work-in-progress. I have about quite a few local modifications as I'm working through the contrib-hls update and I didn't want to lose this in my merge branch somewhere. |
|
@heff updated. Any thoughts or looks good? |
|
LGTM! |
SWF code is still hard to validate so move the logic to fire "seeking" into the js portion of the Flash tech.
Stop firing seeking in the SWF itself.
Add a trigger() to the mock Flash implementation and verify that "seeking" is fired the appropriate number of times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWF code is still hard to validate so move the logic to fire "seeking" into the js portion of the Flash tech. This depends on videojs/video-js-swf#171 to work properly.