Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One font-size transition #2219

Closed
wants to merge 3 commits into from
Closed

One font-size transition #2219

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efa6220
one font-size transition
mmcc May 30, 2015
63f2df2
switched to transition all instead of just font-size
mmcc Jun 5, 2015
b7dda4d
improved centering of the play progress handle
mmcc Jun 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions src/css/components/_progress.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
/**
* Let's talk pixel math!
* Start with a base font size of 10px (assuming that hasn't changed)
* No Hover:
* - Progress holder is 3px
* - Progress handle is 9px
* - Progress handle is pulled up 3px to center it.
*
* Hover:
* - Progress holder becomes 5px
* - Progress handle becomes 15px
* - Progress handle is pulled up 5px to center it
*/

.video-js .vjs-progress-control {
@include flex(auto);
@include display-flex(center);
Expand All @@ -6,21 +20,20 @@
/* Box containing play and load progresses. Also acts as seek scrubber. */
.video-js .vjs-progress-holder {
@include flex(auto);
@include transition(height 0.2s);
@include transition(all 0.2s);
height: 0.3em;
}

/* We need an increased hit area on hover */
.video-js .vjs-progress-control:hover .vjs-progress-holder { height: 0.7em; }
.video-js .vjs-progress-control:hover .vjs-play-progress:before { font-size: 1.7em; } // also increase the size of the handle
.video-js .vjs-progress-control:hover .vjs-progress-holder { font-size: 1.666666666666666666em }

/* Progress Bars */
.video-js .vjs-progress-holder .vjs-play-progress,
.video-js .vjs-progress-holder .vjs-load-progress,
.video-js .vjs-progress-holder .vjs-load-progress div {
position: absolute;
display: block;
height: 100%;
height: 0.3em;
margin: 0;
padding: 0;
/* updated by javascript during playback */
Expand All @@ -36,11 +49,12 @@

// Progress handle
&:before {
@include transition(font-size 0.2s);
position: absolute;
top: -0.35em;
top: -0.333333333333333em;
right: -0.5em;

font-size: 0.9em;
height: 1em;
line-height: 1em;
}
}

Expand Down