Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turkish Translation #1853

Closed
wants to merge 3 commits into from
Closed

Turkish Translation #1853

wants to merge 3 commits into from

Conversation

CuteTechGuy
Copy link
Contributor

Turkish language

@CuteTechGuy CuteTechGuy changed the title Create tr.js Turkish Translation Feb 9, 2015
mmcc
mmcc reviewed Feb 10, 2015
View reviewed changes
lang/tr.json
@@ -0,0 +1,26 @@
videojs.addLanguage("tr",{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary, this file should just be valid JSON.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for help. Im new to github 👍

@mmcc
Copy link
Member

mmcc commented Feb 10, 2015

Thanks for the PR! Fixing my comment should take care of the failing test.

@CuteTechGuy
Copy link
Contributor Author

Fixed. Works well too.

@heff
Copy link
Member

heff commented Feb 11, 2015

looks good to me!

@heff heff closed this in 5c59849 Feb 12, 2015
@heff
Copy link
Member

heff commented Feb 13, 2015

Thanks @ragecub3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
confirmed enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CuteTechGuy @mmcc @heff