-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vjs-scrubbing class to player while scrubbing #1741
Conversation
Thank you! Are you just doing this so you can add |
Which browser did you test it on? Safari appears to block :hover while the mouse is down, but Firefox and IE don't. Haven't checked Chrome. |
Yeah, no issues on Safari or Chrome but I was able to reproduce it on Firefox. Thanks for pointing that out. Would you want to help update the existing menus to use the vis-scrubbing class? |
I currently use this CSS: Not quite sure it necessarily fits in the general case. Also, it might be better to actually have some sort of not-scrubbing class (so we can just have the :hover work only on not-scrubbing, but that probably requires quite a few more changes. |
Nice, I think the first option looks good to me. Want to add it to the pull request? |
Added (slightly edited) CSS rule to video-js.less |
This has been merged into master and will go out with the next release. Thanks Jacques! |
This is useful to add CSS preventing hover menus from opening while scrubbing, even if the mouse strays out of the seek bar.