Warn if options / ready function are passed to a previously created player instance #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Handling this is much needed. |
|
|
||
| // If options or ready funtion are passed, warn | ||
| if (options) { | ||
| vjs.log.warn ('Player "' + id + '" is already initialised. Options will not be applied.'); |
There was a problem hiding this comment.
I wonder if we couldn't still handle options and update the values in this case. Though handling options like children after init would get super complicated, so probably not.
There was a problem hiding this comment.
Deep merging is hard. But otherwise, yes, it could happen.
|
@mister-ben can I get you to make the |
|
Merged into master. Thanks Ben! |
|
Thanks! I've been away with no internet for a couple of weeks, so hadn't been able to get around to that last change. |
|
No problem. Thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are questions fairly regularly on Stack Overflow that come down to confusion over using both
data-setupand passing options and/or a ready function tovideojs().This change logs a message with
vjs.logif options or a ready function are passed as arguments, if a previously created player is returned. It also adds note in the setup doc.