Move manual events into tech controller #1415
Conversation
Migrate the timers that manage creating timeupdate and progress events when the tech doesn't support them natively. Now, techs that extend MediaTechController will continue to automatically pick up synthetic playback and buffering events but they're scoped much more closely to the entity that needs them. In addition, time and progress tracking have been moved much earlier into the component initialization which fixes videojs#1414.
| vjs.Component.prototype.dispose.call(this); | ||
| }; | ||
|
|
||
| vjs.MediaTechController.prototype.setCurrentTime = function() { |
There was a problem hiding this comment.
What if we added a listener to the seeking event instead of having this in the setCurrentTime function? That would avoid needing this include in the sub-techs.
There was a problem hiding this comment.
I'm not seeing seeking or seeked events coming from the Flash player so this won't work. Defer?
There was a problem hiding this comment.
Seeking should be in there.
2f5c9b6f1d919220201f0c1f0bc113a2271a/src/com/videojs/providers/HTTPVideoProvider.as#L522
But I believe we're currently trigger it directly on the player in the case of flash, in case you were listening for it on the tech or the object itself.
There was a problem hiding this comment.
In practice, doesn't seem to be working. Filed videojs/video-js-swf#114 to track it.
|
We're gonna have a few conflicts in this with #1412. This doesn't break any use cases I know of and could be considered a bug, and maybe urgent? I'm ok making it a patch if you want to rebase it on stable. In that case we update the in-production copy on the CDN, so you gotta make sure it's good and tested, including IE8. Other than the inline suggestions, lgtm. |
The major browsers that support HTML video now reliably support progress events, so don't worry about synthesizing them for HTML anymore.
|
Ran the automated test on the latest desktop browsers, IE8, an iPhone, an iPad, and an Android phone and tablet. Did sandbox testing against the latest desktop browsers, IE8, an iPhone, an iPad, and an Android phone and tablet. |
|
The logging test fails on IE8 before the dev console is opened but this occurs in master, too: No other issues. |
Pick up updated flash compiler settings.
|
replaced by #1417 |
Due to videojs#1415, various usage of features moved around. This makes sure that features are now called directly on the tech everywhere.
Migrate the timers that manage creating timeupdate and progress events when the tech doesn't support them natively. Now, techs that extend MediaTechController will continue to automatically pick up synthetic playback and buffering events but they're scoped much more closely to the entity that needs them. In addition, time and progress tracking have been moved much earlier into the component initialization which fixes #1414.
I can rebase this PR off of stable if it should be part of a patch release.