-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create composer.json #1241
Create composer.json #1241
Conversation
Make video js available in PHP projects that uses composer.
So many package managers! I'm not very familiar with the PHP world. How widely adopted is Composer? |
I know package managers are the new rage! I can imagine it's annoying to have a file for each package manager under the sun. Composer is the only PHP package manager I'm aware of that is adopted by the community. All major PHP frameworks are using it: symphony 2, laravel, zend framework 2, codeigniter etc. Let me know if you need more details. |
Ok cool, sounds like this does have some traction. The only real concern is just having a bajillion json config files in the root directory, but in reality that's not a huge deal. I'm fine with this, but ultimately @heff will need to make the call. |
Sorry for the delay, and thanks for the contribution! This was actually proposed back in #195 and I shot it down because it seemed excessive, but now the PHP guys here think it's a decent idea and bootstrap let one through, so I think we can go ahead and add it in. @patforg, are you up for taking ownership of it and keeping it up to date? I was also going to say we should work it into the versioning grunt script, but there's no version in this one or bootstrap's. Does composer not use a version? |
Hi @heff, I have no problem in keeping it up to date, it should require very little maintenance anyways. All I have seen is a grunt-composer plugin which executes composer within grunt, but composer in itself has a way to run scripts. I could be mistaken but I don't think a grunt file would be needed. |
Yeah, sorry, I meant updating the video.js grunt file. We have a grunt script that, when we make a new releases, will update the video.js version in the package.json, bower.json, and component.json. But composer.json doesn't appear to need a version? Do you know where the version of a package is tracked for composer, and is there anything we need to do in addition to adding the composer.json file? |
HI Heff, Oh got it now. I've updated the version to 4.6.4 in all 3 files. There is a version in the composer file but if omitted it takes the versions from tags and branches in the repository. Optionally you can register the package with packagist.org, which is the main repository of packages. |
Oh man, sorry for the confusion. I didn't mean for you to actually update those versions. That's what the grunt script is used for. Now I actually need you to undo that last change and put the versions back to where they were...sorry. Thanks for clearing up how composer versions work though. That's pretty nice that it can just read the tags. I'll register this will packagist after I pull this in. |
Here the changes were undone. Let me know if I need to do anything else. |
done. Thanks! |
And published to packagist. https://packagist.org/packages/videojs/video.js Though it doesn't appear to be picking up the tagged versions? You'll have to try to install it and see if it uses the latest version tag or just master. |
Make video js available in PHP projects that uses composer.