-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser crashes when progressControl is true under IE11 #5575
Comments
👋 Thanks for opening your first issue here! 👋 If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
The progress control is enabled by default and Video.js works fine in IE11Win10. Can you provide a test case of your scenario? Also, I just tried the following option and didn't see any unexpected spike in CPU: var player = videojs(vid, {
progressControl: true
}); |
You have to minimize the IE window to see what I said. If you keep the window visible, it won't happen. What I said is the problem. If CPU goes up, the IE window will be maximized at this point, and CPU usage will drop to normal. |
I can reproduce that, though, when verifying on a page with just Video.js, it doesn't get as high. Also, it drops when the video isn't playing. |
Will this performance problem be solved in the near future? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I've been able to track down the issue an opened #5879 which I believe fixes the problem. |
…5879) The seek bar updates on a 30ms interval to have a nice, smooth transition as time ticks forward. Unfortunately, IE11 has some performance issues with interval when the document is hidden. This doesn't appear to be an issue when using setTimeout but using a setTimeout was causing the play progress to appear very jerky in comparison. Instead, we should just not update the play progress when the document is hidden. Besides solving the issue in IE11, it makes sense to do as no one could be seeing the progress bar. In addition, update() is now a no-op if the seek-bar element isn't visible. Fixes #5575
Description
Briefly describe the issue.
Include a reduced test case, we have a starter template on JSBin you can use.
Steps to reproduce
Explain in detail the exact steps necessary to reproduce the issue.
When I play an MP4 video with Videojs under IE11, when the progressControl is set to true, the browser will be minimized, and the CPU will rise to 30%, causing the IE browser to become unresponsive. If the progressControl is set to false, the CPU usage will be Stay at around 2% and there will be no browser stuck
Results
IE cpu usage rate soared, causing page stuck
Expected
Don't want to crash under IE
Please describe what you expected to see.
I don't expect this kind of CPU rise to cause a stuck problem.
Actual
Please describe what actually happened.
CPU
Error output
If there are any errors at all, please include them here.
Additional Information
Please include any additional information necessary here. Including the following:
versions
videojs
what version of videojs does te
his occur with?
7.3.0
browsers
what browser are affected?
IE
OSes
what platforms (operating systems and devices) are affected?
WIN 10
plugins
are any videojs plugins being used on the page? If so, please list them below.
The text was updated successfully, but these errors were encountered: