Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed position to absolute #5355

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Changed position to absolute #5355

merged 1 commit into from
Jul 31, 2018

Conversation

decarbonite
Copy link
Contributor

@decarbonite decarbonite commented Jul 30, 2018 •
edited by ldayananda
Loading

Description

Changed tooltips position from relative to absolute
Issue #5354

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev gkatsev merged commit 4b666f9 into videojs:master Jul 31, 2018
@gkatsev
Copy link
Member

gkatsev commented Jul 31, 2018

Thanks for the PR @decarbonite!

@gkatsev gkatsev mentioned this pull request Jul 31, 2018
Closed
5 tasks
gkatsev pushed a commit that referenced this pull request Aug 13, 2018
@decarbonite @gkatsev
fix: change time tooltips to be absolutely positioned (#5355)
91839d8 
Fixes #5351
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@decarbonite @gkatsev @misteroneill