Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change time tooltips to be absolutely positioned #5354

Closed
5 tasks
first-timers bot opened this issue Jul 30, 2018 · 6 comments
Closed
5 tasks

fix: change time tooltips to be absolutely positioned #5354

first-timers bot opened this issue Jul 30, 2018 · 6 comments

Comments

@first-timers
Copy link

first-timers bot commented Jul 30, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

Once claimed, we'll remove the 'unclaimed' label from the issue so others will know not to work on it.

@@ -114,7 +114,7 @@
   font-size: 1em;
   padding: 6px 8px 8px 8px;
   pointer-events: none;
-  position: relative;
+  position: absolute;
   top: -3.4em;
   visibility: hidden;
   z-index: 1;
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below! Alternatively, drop by our slack's #discussion channel.

This issue was created by First-Timers-Bot.

@decarbonite
Copy link
Contributor

Hello, may I claim this issue please?

@gkatsev
Copy link
Member

gkatsev commented Jul 30, 2018

@decarbonite you got it!

@gkatsev gkatsev removed the unclaimed label Jul 30, 2018
@Neidley
Copy link

Neidley commented Jul 30, 2018

Hello :) May I claim this issue?

@gkatsev
Copy link
Member

gkatsev commented Jul 30, 2018

@Neidley hey, unfortunately, it's already been claimed :(

@decarbonite
Copy link
Contributor

@gkatsev I opened the pull request, could you please review it? Thanks

@gkatsev
Copy link
Member

gkatsev commented Jul 31, 2018

Fixed via #5355. πŸŽ‰

@gkatsev gkatsev closed this as completed Jul 31, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants