Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all missing translation for CZ_cs #5311

Merged
merged 3 commits into from
Jul 24, 2018
Merged

Added all missing translation for CZ_cs #5311

merged 3 commits into from
Jul 24, 2018

Conversation

Akxe
Copy link
Contributor

@Akxe Akxe commented Jul 11, 2018

Don't know how to translate caption and description, they are now noted with exclamation point as this: !caption!. Upon explanation I can hopefully translate them too.

Don't know how to translate caption and description, they are now noted with exclamation point as this: !caption!. Upon explanation I can hopefully translate them too.
@gkatsev
Copy link
Member

gkatsev commented Jul 11, 2018

Captions are a specific subset of Subtitles. Subtitles, for example, only have spoken word, but captions include other auditory cues like sound effects or music.
Descriptions are basically subtitles that go beyond even further and will actually describe the video in detail. Like what the characters are doing or the scenery.
@OwenEdwards did you have anything to add?

I am not sure about captions thought...
@Akxe
Copy link
Contributor Author

Akxe commented Jul 11, 2018

Added those two, description is in czech translated as subtitles for blind, but I wasn't sure about captions... maybe some day, someone will translate it better...

@Akxe
Copy link
Contributor Author

Akxe commented Jul 11, 2018

Also, a bit offside, but I am trying to translate subtitle settings window, but none of the values translates, was it added in version 7 of VideoJS, or am I missing something? (using lastest v6)

@gkatsev
Copy link
Member

gkatsev commented Jul 11, 2018

captions is often called subtitles for the hard of hearing.
descriptions as subtitles for the blind is probably good enough.

the subtitle settings has been around for a long time. Make sure you aren't forcing native subtitles and it is only available for our non-native subtitles.

"Fullscreen": "Celá obrazovka",
"Non-Fullscreen": "Zmenšená obrazovka",
"Mute": "Ztlumit zvuk",
"Unmute": "Přehrát zvuk",
"Playback Rate": "Rychlost přehrávání",
"Subtitles": "Titulky",
"subtitles off": "Titulky vypnuty",
"subtitles off": "Bez titulků",
"Captions": "Popisky",
Copy link
Member

@OwenEdwards OwenEdwards Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Google Translate for "Subtitles for the Deaf" or "Subtitles for the Hard of Hearing", I get "Titulky pro neslyšící", whereas "Popisky" gets translated back as "labels" or "descriptions". Would that make sense?

"Captions": "Popisky",
"captions off": "Popisky vypnuty",
"Chapters": "Kapitoly",
"Descriptions": "Popisky",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, using Google Translate, "Descriptions for the Blind" comes back as "Popisy pro nevidomé" - does that work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Popisky" for captions is perfect! With description it works for both, "popisek" is more like more like describe, so it may make more sense.

@Akxe
Copy link
Contributor Author

Akxe commented Jul 12, 2018

This should be final, but I am still not seeing my translations on subtitle settings window, more in #5316.

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Jul 20, 2018
@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Jul 24, 2018
@gkatsev gkatsev merged commit e63d235 into videojs:master Jul 24, 2018
@gkatsev
Copy link
Member

gkatsev commented Jul 24, 2018

Thanks @Akxe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants