Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middle mouse can play/pause videojs #4689

Closed
kocoten1992 opened this issue Oct 25, 2017 · 6 comments · Fixed by #4756
Closed

Middle mouse can play/pause videojs #4689

kocoten1992 opened this issue Oct 25, 2017 · 6 comments · Fixed by #4756

Comments

@kocoten1992
Copy link
Contributor

kocoten1992 commented Oct 25, 2017 •
edited
Loading

Steps to reproduce

  1. go to videojs.com
  2. press play
  3. now, you can use middle mouse to play/pause video (click on the video, not triangle play button)

Expected

Shouldn't be able to do that

Problem might be here:
https://github.com/videojs/video.js/blob/master/src/js/player.js#L1384

Related issue: #4611 (fixing that will give enough experience to fix this)
@gkatsev
Copy link
Member

gkatsev commented Oct 25, 2017

I wasn't able to reproduce but I can definitely see it happening on some browsers and OSes.

kocoten1992 added a commit to kocoten1992/video.js that referenced this issue Nov 17, 2017
@kocoten1992
refactor player.handleTechClick_() + small tweak
221a937 
fix videojs#4689
@kocoten1992 kocoten1992 mentioned this issue Nov 17, 2017
Merged
2 tasks
gkatsev pushed a commit that referenced this issue Nov 17, 2017
@kocoten1992 @gkatsev
fix: being able to toggle playback with middle click (#4756)
7a776ee 
Uses the new Dom.isSingleLeftClick method to do the check we were doing previously.
Also, refactor the player.handleTechClick_() method to follow the new style of code.

Fixes #4689
@sziberov
Copy link

Can do this too.
v5.4.6
Opera Developer
Windows 10

@gkatsev
Copy link
Member

gkatsev commented Nov 22, 2017

@sziberov it's fixed in 6.5.0, please give that a try!

@sziberov
Copy link

sziberov commented Nov 26, 2017 •
edited
Loading

@gkatsev Yeah, it is, but time tooltip and volume bar styling completely broken now. What I can do?

@kocoten1992
Copy link
Contributor Author

@sziberov open new issue, take a picture before and after maybe, I recall the slider have box-shadow (but never really show before, only show after fix the left click), didn't recall time tooltip though

@elypter elypter mentioned this issue Mar 19, 2020
Closed
@elypter
Copy link

elypter commented Mar 20, 2020

i can reproduce the problem on the official demo https://videojs.com/city and im using firefox on windows 10

@elypter elypter mentioned this issue Mar 21, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor player.handleTechClick_() + small fix kocoten1992/video.js
4 participants
@gkatsev @elypter @kocoten1992 @sziberov