fix: Safari picture-in-picture triggers fullscreenchange #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Jun 25, 2017
|
I guess we'll want to also fix this in 5.x. |
3 tasks
gkatsev
pushed a commit
that referenced
this pull request
Jul 4, 2017
When picture-in-picture mode is entered on Safari, `webkitbeginfullscreen` is triggered which results in a proxied `fullscreenchange` event and adding the fullscreen class to the player. That causes the tech element to collapse to zero height so that the "this video is playing in picture in picture" placeholder is not visible. As with #4437 for v6, on `webkitbeginfullscreen` check whether the presentation mode is picture-in-picture' before proxying a `fullscreenchange` event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When picture-in-picture mode is entered on Safari,
webkitbeginfullscreenis triggered which results in a proxiedfullscreenchangeevent and adding the fullscreen class to the player. That causes the tech element to collapse to zero height so that the "this video is playing in picture in picture" placeholder is not visible.Specific Changes proposed
On
webkitbeginfullscreencheck whether the presentation mode ispicture-in-picturebefore proxying afullscreenchangeevent.Requirements Checklist