Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE10: Unexpected call to method or property access #4378

Closed
jetfontanilla opened this issue May 25, 2017 · 2 comments
Closed

IE10: Unexpected call to method or property access #4378

jetfontanilla opened this issue May 25, 2017 · 2 comments

Comments

@jetfontanilla
Copy link

jetfontanilla commented May 25, 2017

Description

JS error on IE10 with HTML5 tech causing entire JS execution to break

Steps to reproduce

  1. multiple videoJS instances on same page reproducible even with a single player instance
  2. when one video instance ends, JS error gets triggered

Results

SCRIPT65535: Unexpected call to method or property access.
audio-track-list.js (44,1)

Expected

var disableOthers = function disableOthers(list, track) {
  for (var i = 0; i < list.length; i++) {
    if (track.id === list[i].id) {
      continue;
    }
    // another audio track is enabled, disable it
    list[i].enabled = false;
  }
};

in this function, list[i] would return an empty Object {} without an id property causing said issue
causes the rest of the JS execution to break when this triggers

any way to disable the disableOthers() function or fix this issue? I'm not using any audioTracks for the videos.

Thanks!

Additional Information

IE10
videojs: 5.16.2

@jetfontanilla
Copy link
Author

update:
it looks like this happens even with only one instance of the player on IE10

jetfontanilla added a commit to jetfontanilla/video.js that referenced this issue Jun 5, 2017
videojs#4378 fix IE10 issue for disableOthers
jetfontanilla added a commit to jetfontanilla/video.js that referenced this issue Jun 5, 2017
videojs#4378 fix IE10 issue for disableOthers
jetfontanilla added a commit to jetfontanilla/video.js that referenced this issue Jun 5, 2017
videojs#4378 fix IE10 issue for disableOthers
jetfontanilla added a commit to jetfontanilla/video.js that referenced this issue Jun 5, 2017
videojs#4378 fix IE10 issue for disableOthers
jetfontanilla added a commit to jetfontanilla/video.js that referenced this issue Jun 5, 2017
@jetfontanilla
Copy link
Author

created a PR to fix this issue on v6.2
#4395

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant