Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap MenuItem text in a span #4017

Closed
gkatsev opened this issue Feb 1, 2017 · 0 comments
Closed

Wrap MenuItem text in a span #4017

gkatsev opened this issue Feb 1, 2017 · 0 comments
Assignees
@gkatsev
Labels
a11y This item might affect the accessibility of the player

Comments

@gkatsev
Copy link
Member

gkatsev commented Feb 1, 2017

Similar to #3982 and was brought up in #4006. We should wrap MenuItem text in span and potentially add an icon-placehold span next to it if we wanted to add icons. It'll make for a more consisten DOM structure and allow for better handling of assistive technology.
@gkatsev gkatsev added the a11y This item might affect the accessibility of the player label Feb 1, 2017
@gkatsev gkatsev mentioned this issue Feb 1, 2017
Merged
@gkatsev gkatsev self-assigned this Feb 2, 2017
gkatsev added a commit that referenced this issue Feb 2, 2017
@gkatsev
feat: wrap menu item text in a span
36a78eb 
Fix #4017
@gkatsev gkatsev mentioned this issue Feb 2, 2017
Merged
gkatsev added a commit that referenced this issue Feb 3, 2017
@gkatsev
feat: wrap menu item text in a span (#4026)
5748c36 
Fix #4017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gkatsev gkatsev

Labels
a11y This item might affect the accessibility of the player
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkatsev