Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cues are sometimes undefined in the updateForTrack function #2870

Closed
imbcmdth opened this issue Dec 1, 2015 · 1 comment
Closed

Cues are sometimes undefined in the updateForTrack function #2870

imbcmdth opened this issue Dec 1, 2015 · 1 comment
Milestone

Comments

@imbcmdth
Copy link
Member

imbcmdth commented Dec 1, 2015

I have seen several instances where TextTrackDisplay.prototype.updateForTrack tries to use cues that are undefined. In the cues array, I see that there are entries that are undefined.

This happens occasionally and the only time I have seen this behavior is when using 608 captions with the latest contrib-hls.

@gkatsev gkatsev added this to the Text Tracks milestone Dec 1, 2015
gkatsev added a commit to gkatsev/video.js that referenced this issue Dec 8, 2015
@gkatsev
Copy link
Member

gkatsev commented Dec 8, 2015

Fixed #2896

@gkatsev gkatsev mentioned this issue Dec 8, 2015
7 tasks
@gkatsev gkatsev closed this as completed in 5bb1a76 Dec 8, 2015
jgubman added a commit to jgubman/video.js that referenced this issue Jan 27, 2016
* upstream/stable: (479 commits)
  v5.4.4
  @gkatsev switched to use custom vtt.js from npm. closes videojs#2905
  v5.4.3
  @gkatsev updated options customizer and github-release options. closes videojs#2903
  v5.4.2
  @gkatsev updated grunt-release config. closes videojs#2900
  v5.4.1
  @gkatsev added chg- and github- release for next releases. closes videojs#2899
  v5.4.0
  @gkatsev added ability to release next tag from master. closes videojs#2894
  @gkatsev added nullcheck for cues in updateForTrack. Fixes videojs#2870. closes videojs#2896
  @chemoish emulated HTMLTrackElement to enable track load events. closes videojs#2804
  @gkatsev added a Player#reset method. Fixes videojs#2852. closes videojs#2880
  @nick11703 changed multiline comments in sass with single-line comments. closes videojs#2827
  @gkatsev added Player#tech. Fixes videojs#2617. closes videojs#2883
  @misteroneill updated videojs-ie8 to 1.1.1. closes videojs#2869
  v5.3.0
  @imbcmdth added sourceOrder option for source-first ordering in selectSource. closes videojs#2847
  @forbesjo updated formatTime to not go negative. closes videojs#2821
  v5.2.4
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants