Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Movement of keyboard focus from the 'big play' button to the full control bar to support keyboard accessibility #2729

Closed
OwenEdwards opened this issue Oct 23, 2015 · 2 comments · Fixed by #4018
Closed

Movement of keyboard focus from the 'big play' button to the full control bar to support keyboard accessibility #2729

OwenEdwards opened this issue Oct 23, 2015 · 2 comments · Fixed by #4018
Assignees
@gkatsev
Labels
a11y This item might affect the accessibility of the player confirmed
Milestone
WCAG 2.0 Compliance

Comments

@OwenEdwards
Copy link
Member

A couple of changes would fix accessibility issues related to the 'big play' button:

  1. When the big play button is activated using the keyboard, focus should be moved to the regular play button in the control bar
  2. There should be some indication to screen reader users that only the big play button is available before playback is started, and that the full control bar will become available when play starts (or that it has become available once the big play button has been activated, but this is not an ideal solution because that is the point when audio from the video playback will start).

This is related to, but distinct from. #2156.
@OwenEdwards OwenEdwards added this to the WCAG 2.0 Compliance milestone Oct 23, 2015
@OwenEdwards OwenEdwards changed the title The change from the 'big play' button to the full control bar needs to be made accessible Movement of keyboard focus from the 'big play' button to the full control bar to support keyboard accessibility Nov 3, 2015
@OwenEdwards OwenEdwards added the a11y This item might affect the accessibility of the player label Jan 22, 2016
@OwenEdwards OwenEdwards mentioned this issue Jan 26, 2016
Closed
@chrisauclair
Copy link
Contributor

Can we expect a fix for this before 6.0?

@gkatsev
Copy link
Member

gkatsev commented Mar 23, 2016

@chrisauclair yeah, I think that this change can definitely be made without a major release. PRs are always welcome but otherwise, it may be a while before this lands.

gkatsev added a commit that referenced this issue Feb 1, 2017
@gkatsev
fix: focus play toggle from Big Play Btn on play
4768b59 
If the control bar and playtoggle exist, focus the playtoggle after
triggering play via the keyboard from the Big Play Button.
If `play()` returns a promise, wait until it resolves to focus,
otherwise, use a setTimeout.

Fixes #2729
@gkatsev gkatsev mentioned this issue Feb 1, 2017
Merged
@gkatsev gkatsev self-assigned this Feb 2, 2017
gkatsev added a commit that referenced this issue Feb 3, 2017
@gkatsev
fix: focus play toggle from Big Play Btn on play (#4018)
4f79e1e 
If the control bar and playtoggle exist, focus the playtoggle after
triggering play via the keyboard from the Big Play Button.
If the control bar isn't available, then focus the player element.
If play() returns a promise, wait until it resolves to focus,
otherwise, use a setTimeout.

Fixes #2729
gkatsev added a commit that referenced this issue Feb 23, 2017
@gkatsev
fix: focus play toggle from Big Play Btn on play (#4018)
56543b3 
If the control bar and playtoggle exist, focus the playtoggle after
triggering play via the keyboard from the Big Play Button.
If the control bar isn't available, then focus the player element.
If play() returns a promise, wait until it resolves to focus,
otherwise, use a setTimeout.

Fixes #2729
gkatsev added a commit that referenced this issue Feb 27, 2017
@gkatsev
feat: focus play toggle from Big Play Btn on play (#4132)
dcc615a 
If the control bar and playtoggle exist, focus the playtoggle after
triggering play via the keyboard from the Big Play Button.
If the control bar isn't available, then focus the player element.
Adds focus() and blur() on components.

This is a port of #4018.

Fixes #2729 for the 5.x branch.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gkatsev gkatsev

Labels
a11y This item might affect the accessibility of the player confirmed
Projects
None yet
Milestone
WCAG 2.0 Compliance
Development

Successfully merging a pull request may close this issue.

fix: focus play toggle from Big Play Btn on play videojs/video.js
3 participants
@gkatsev @OwenEdwards @chrisauclair