Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the plugins before the components #1980

Closed
carpasse opened this issue Mar 26, 2015 · 3 comments
Closed

Initialize the plugins before the components #1980

carpasse opened this issue Mar 26, 2015 · 3 comments

Comments

@carpasse
Copy link
Contributor

Hi guys.

I use the plugins to get the data needed for the controls of the player.
I usually use the plugins to get the data and have a separation between the business logic and the UI (Components) therefore I would like to propose that we initialize the plugins before we initialize the components.

What do you think??

@carpasse
Copy link
Contributor Author

Another possibility would be to enhance the build phase of a component to specify dependencies to a list of plugins

@heff
Copy link
Member

heff commented Mar 29, 2015

Yeah, I think initializing plugins before controls is a good idea. Some plugins need the controls to be there already when they're loaded, however those plugins could now wait for the ready event, whereas today there's no option for plugins that need to modify the controls ahead of time.

I'd be interested to know @dmlap and @gkatsev's thoughts on this since they've had the most experience building plugins. For instance, if the ready event will work for that.

Confirming for 5.0 unless we hear differently. This would be a pretty big API breaking change for plugins so we would need to figure it out quickly if we want to get it in.

The dependencies issue is one we've been talking about off an on, and might be worth opening another issue for. We're running into it more and more. Basically, everything in the video.js ecosystem is a peer dependency, even video.js itself, and npm peer dependencies aren't so great, so it's been a challenge figuring out the best approach.

@heff heff added this to the v5.0.0 milestone Mar 29, 2015
bc-bbay added a commit to bc-bbay/video.js that referenced this issue Apr 27, 2015
bc-bbay added a commit to bc-bbay/video.js that referenced this issue Apr 28, 2015
bc-bbay added a commit to bc-bbay/video.js that referenced this issue Apr 29, 2015
@heff
Copy link
Member

heff commented May 1, 2015

Closed by #2094

@heff heff closed this as completed May 1, 2015
bc-bbay added a commit to bc-bbay/video.js that referenced this issue Aug 31, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants