Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebVTT --> should support tabs #183

Closed
heff opened this issue May 4, 2012 · 3 comments
Closed

WebVTT --> should support tabs #183

heff opened this issue May 4, 2012 · 3 comments
Labels
confirmed enhancement unclaimed

Comments

@heff
Copy link
Member

heff commented May 4, 2012

Looks like it has a bug in that it requires "-->" to have spaces around it when parsing (but not when identifying the line type)... But the spec allows tabs or spaces...
@heff
Copy link
Member Author

heff commented May 4, 2012

http://dev.w3.org/html5/webvtt/#webvtt-cue-timings

@heff heff added the confirmed label Mar 5, 2014
heff added a commit that referenced this issue May 22, 2014
@heff
Added tests for cue time parsing, including for #183 (test-only)
aedaa17
@heff
Copy link
Member Author

heff commented May 22, 2014

Added tests for this. Uncomment these lines to test a fix for this issue.
aedaa17#diff-85f8bbd2ee88763c24c537a927dffc6bR46

@heff heff mentioned this issue May 28, 2014
Closed
trmb added a commit to trmb/video.js that referenced this issue May 29, 2014
@trmb
When breaking the cue time line apart, split on
d189691 
one or more tabs and/or spaces fixes videojs#183
Uncommented tests, added new ones for multi and
mixed whitespace cases
@trmb
Copy link
Contributor

trmb commented May 29, 2014

This should be fixed in pull request #1236. "-->" can now be wrapped by one or more tabs or spaces.

@heff heff closed this as completed in bb50466 Jun 13, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed enhancement unclaimed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heff @trmb