Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default subtitle on but [subtitle off] stays visually active. #1370

Closed
jerrylow opened this issue Jul 25, 2014 · 2 comments
Closed

Default subtitle on but [subtitle off] stays visually active. #1370

jerrylow opened this issue Jul 25, 2014 · 2 comments
Labels
bug confirmed

Comments

@jerrylow
Copy link
Contributor

The default setting on the track from #1011 works but the "subtitles off" option still has the .vjs-selected class.
@jerrylow jerrylow mentioned this issue Jul 25, 2014
Closed
@jerrylow
Copy link
Contributor Author

Is this a feasible fix? #1371

@heff
Copy link
Member

heff commented Jul 25, 2014

What if we replace track.show() with player.showTextTrack which already triggers the event. Would that work?

@heff heff added bug labels Jul 25, 2014
@heff heff closed this as completed in fa5116f Aug 2, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heff @jerrylow