Default subtitle not working

[tomasdev]

As per https://github.com/videojs/video.js/blob/v4.3.0/docs/guides/tracks.md it reads a default attribute but even with that property set on the <track> element, subtitles won't load by default.

On the code at vjs.TextTrack.prototype.show it says:

• The showing by default state is used in conjunction with the default attribute on track elements to indicate that the text track was enabled due to that attribute.

It feels to me like it's a bug, and the code isn't handling the default attribute on children tracks correctly.

Setup code:

<video autoplay id="video_player" width="100%" height="100%" class="video-js vjs-default-skin" controls>
        <source src="video" type="video/mp4" />
        <track kind="subtitles" src="validUrl.srt" default srclang="es" label="Spanish" />
</video>

And obviously call videojs('video_player'); in JavaScript

[tomasdev]

Duplicated of #656

[heff]

Thanks for closing the duplicate. I hope we can get that solved soon, but focused on other things like HLS right now.

[tomasdev]

@heff we could do a PR with the if commented at #656, tho

[heff]

Did that fix the issue for you? I feel like I tried that quickly and it didn't work as expected. Forgetting the specific details though.

[tomasdev]

@heff yes it did.

[heff]

Ok, then yeah, a PR would be helpful.