Allow for webkit-playsinline

[dcharbonnier]

There is currently no way to use videojs to play a video inline on iOS devices .

webkit-playsinline
Indicates that a video element should play inline instead of full-screen. Enabled only in a UIWebView with the allowsInlineMediaPlayback property set to YES.
Related Tags : video
Availability : Available in iOS 4.0 and later.

https://developer.apple.com/library/safari/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/Attributes.html#//apple_ref/doc/uid/TP40008058-SW30

Related to #896, #314 copy attributes but don't provide an option.

[mmcc]

I'm not sure what you mean by "copy attributes but don't provide an option". If the attribute is persisted when moving the video element (as #314 fixed), it sounds like we're doing everything we can to support this tag from our side.

[dcharbonnier]

for autoplay you provide option or data-options, not for this attibute, this is just not consistent

[dcharbonnier]

and does not work with plugin like youtube, youtube plugin remove the video tag, if you have a playlist mixing different technologies, the video tag is not re-created with the correct attributes.

[mmcc]

Ok I think we're talking about a few different things here. Would you please give an example of what we don't support regarding autoplay or webkit-playsinline?

Regarding the YouTube plugin, that specifically is an issue you'll have to take up with the maintainer (but I don't think he'll be able to help there because, YouTube).

[dcharbonnier]

Ok, I'm not clear and there is definitely a problem, let me explain the use case 👍

1/ Consider a html page containing a video tag with webkit-playsinline, and the plugin youtube (youtube plugin is an example and there is no problem with this plugin, the only thing relevant is that the plugin dispose the video attribute)
2/ with javascript play a youtube video.
3/ with javascript play a mp4 video

at step 3 we expect the webkit-playsinline to exist, and you understand why it's not the case, nothing on getAttributeValues to get the value and no option to tell videojs to use this attribute.

[gkatsev]

Does the process you described work if step two didn't exist?

[dcharbonnier]

@gkatsev, no but the part of code in charge of re-creating the video element is video.js, not videos-youtube, so this is a videojs problem. More over we already have this inconsistency on having no javascript interface for this specific attribute (we have one for autoplay for example).

[mmcc]

I don't know how I feel about adding this to the API. It's not in the W3C spec and is entirely iOS-specific, so I think we shouldn't necessarily be explicitly adding this.

That being said, @gkatsev and I just talked about this briefly in IRC and he made the excellent point that we should do a better job of restoring all attributes when re-creating an element. This would allow us to future-proof ourselves from additional namespaced attributes like this for any platform rather than needing to add an API for each one.

[dcharbonnier]

perfect, let's close this pull request, I will sent a new one, thank you.

[mmcc]

Awesome! Thank you so much for the help, @dcharbonnier.

[mmcc]

The PR has been merged! Thanks for the help!

[dcharbonnier]

it's not and you still have the bug, if someone need that, use my fork

[mmcc]

Argh, that's my fault. I saw the El issue get merged and totally misread that.

[dcharbonnier]

yes I had the same impression

[mmcc]

Soon :)

[heff]

NOW it's merged in. :)

[dcharbonnier]

youhou, MERCI !

[rapsody]

Has this been added to the latest release v4.12.13? I have added playsinline': true, to my videoJs setup and its not detecting it.

[DieterPagel]

Does anyone perhaps have a working code example for me on how to play video inline on iOS? We have read extensively in the forums and tried all suggestions but we just can't seem to get it to work