Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vjs-has-started not being added on init #1207

Closed
dmlap opened this issue May 14, 2014 · 1 comment
Closed

vjs-has-started not being added on init #1207

dmlap opened this issue May 14, 2014 · 1 comment

Comments

@dmlap
Copy link
Member

dmlap commented May 14, 2014

The fix for #1050 changes the order of event handler registrations slightly and can mean that vjs-has-started is not added to the player. Before 95c29e6, the first play event triggered on the player would add vjs-has-started. After the change, loadstart has to be triggered before play. If the sources are specified through the player options object, loadstart occurs when the player invokes its prototype constructor, before the player loadstart handler is registered.

dmlap added a commit to dmlap/video.js that referenced this issue May 14, 2014
…he event. Fixes videojs#1207.

Check if the player already has a currentSrc on load and call the loadstart handler explicitly. This ensures that the first play listener is properly registered before playback begins.
heff added a commit to heff/video.js that referenced this issue May 14, 2014
@heff heff closed this as completed in bad5130 May 14, 2014
@heff
Copy link
Member

heff commented May 14, 2014

If you try master now it should work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants