Skip to content

Commit

Permalink
Warning for previously updated players; doc update
Browse files Browse the repository at this point in the history
  • Loading branch information
mister-ben authored and heff committed Dec 22, 2014
1 parent a67201f commit fc0730d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/guides/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ Step 2: Add an HTML5 video tag to your page.
--------------------------------------------
With Video.js you just use an HTML5 video tag to embed a video. Video.js will then read the tag and make it work in all browsers, not just ones that support HTML5 video. Beyond the basic markup, Video.js needs a few extra pieces.

> Note: The `data-setup` attribute described here should not be used if you use the alternative setup described in the next section.
1. The 'data-setup' Attribute tells Video.js to automatically set up the video when the page is ready, and read any options (in JSON format) from the attribute (see [options](options.md)). There are other methods for initializing the player, but this is the easiest.

2. The 'id' Attribute: Should be used and unique for every video on the same page.
Expand Down
9 changes: 9 additions & 0 deletions src/js/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ var vjs = function(id, options, ready){

// If a player instance has already been created for this ID return it.
if (vjs.players[id]) {

// If options or ready funtion are passed, warn
if (options) {
vjs.log.warn ('Player "' + id + '" is already initialised. Options will not be applied.');
}
if (ready) {
vjs.log.warn ('Player "' + id + '" is already initialised. Ready function will not be executed.');
}

return vjs.players[id];

// Otherwise get element for ID
Expand Down

0 comments on commit fc0730d

Please sign in to comment.