Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: improve ts output for create logger (#8763)
## Description Typescript =< 5.2 generated better types for `log` than >= 5.3. We're on 5.5 as that has the better import syntax. Changing createLogger to use `function log()` rather than `const log = function()` outputs as before. Also updates typescript to 5.5.1 (rc) from 5.5.0 (beta). 5.2, or 5.5 with this change ``` export default log; declare const log: { (...args: any[]): void; createLogger(subName: string, subDelimiter?: string, subStyles?: string): any; createNewLogger(newName: string, newDelimiter?: string, newStyles?: string): any; levels: any; level(lvl?: "info" | "error" | "all" | "debug" | "warn" | "off"): string; history: { (): any[]; filter(fname: string): any[]; clear(): void; disable(): void; enable(): void; }; error(...args: any[]): any; warn(...args: any[]): any; debug(...args: any[]): any; }; export const createLogger: (subName: string, subDelimiter?: string, subStyles?: string) => any; //# sourceMappingURL=log.d.ts.map% ``` 5.3+, without this change ``` export default log; declare function log(...args: any[]): void; declare namespace log { } export const createLogger: (subName: string, subDelimiter?: string, subStyles?: string) => any; //# sourceMappingURL=log.d.ts.map% ``` ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [ ] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
- Loading branch information