This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Set hasEnded false on a seek, remove another seek after end request #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -301,7 +301,6 @@ package com.videojs.providers{ | |||
| // if the asset is already loading | |||
| if (_hasEnded) { | |||
| _hasEnded = false; | |||
| _ns.seek(0); | |||
There was a problem hiding this comment.
This is what makes it that if you seek immediately after ending, you actually start at 0 instead of where you seeked?
Though, changing this seems like it might break replay functionality when you hit play after the video has ended.
There was a problem hiding this comment.
Looping continues to work fine.
I'm not sure when this code is actually being used, as it doesn't seem to be interfering with anything, but since we've decided to let the player (not the tech) decide when/whether to reset, this should still go.
|
LGTM. |
bc-bbay
added a commit
that referenced
this pull request
Jul 30, 2015
Set hasEnded false on a seek, remove another seek after end request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.