Feat/parse codec #14
Feat/parse codec #14
Conversation
brandonocasey
force-pushed
the
feat/parse-codec
branch
from
3122fe3 to
e813a49
Compare
fix content generation script dist path add ec-3 in an ac3 container
brandonocasey
force-pushed
the
feat/parse-codec
branch
from
900b046 to
e077a4c
Compare
brandonocasey
force-pushed
the
feat/parse-codec
branch
from
72d581a to
c372919
Compare
| ]; | ||
|
|
||
| const videoCodecs = [ | ||
| // TODO: use another encoder, ffmpeg does not support codecPrivate for vp09 |
There was a problem hiding this comment.
Is this something important to have? Maybe we can just generate a one off file for it?
There was a problem hiding this comment.
Not super important, but it would certainly help verify that we are doing parsing correctly, it would be good to get eventually.
src/containers.js
Outdated
| // ac3 sync byte | ||
| 'ac3': toUint8([0x0b, 0x77]), |
There was a problem hiding this comment.
ec-3 is kind of like a codec contained within the ac3 container
There was a problem hiding this comment.
Yeah, that's what I thought but wasn't sure. I think it's worth adding a comment here saying that this covers ec-3 as well.
|
Once I write up the usage for |
…rsing codecs from files (#14) BREAKING CHANGE: toUint8 in byte-helpers functions slightly differently BREAKING CHANGE: getId3Offset is exported from id3-helpers rather than containers We can now parse the container for and many of the codecs within (where applicable) for mp4, avi, ts, mkv, webm, ogg, wav, aac, ac3 (and ec3 which is contained in ac3 files), mp3, flac, raw h265, and raw h264. Codec parsing has also been extended to parse codec details in a file for vp09, avc (h264), hevc (h265), av1, and opus Finally we have the following additional features to our parsing of codec/container information: * skipping multiple id3 tags at the start of a file for flac, mp3, and aac * discarding emulation prevention bits (in h264, h265) * parsing raw h264/h265 to get codec params for ts, avi, and even raw h264/h265 files
Notes for code Review:
formats/*bin/big-buck-bunny.mp4Description/Features
Parse the following container formats and the codecs that they have:
Also parses specific codec parameters where available for:
Finally we handle: