feat: use vhs-utils #361
Open
feat: use vhs-utils #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Dec 16, 2020
brandonocasey
force-pushed
the
feat/vhs-utils
branch
3 times, most recently
from
b1e6a8f to
4708fb1
Compare
brandonocasey
commented
Dec 18, 2020
| @@ -144,7 +144,7 @@ module.exports.sampleMoov = | |||
| box('stsd', | |||
| 0x01, // version 1 | |||
| 0x00, 0x00, 0x00, // flags | |||
| 0x00, 0x00, 0x00, 0x00, // entry_count | |||
| 0x00, 0x00, 0x00, 0x01, // entry_count | |||
There was a problem hiding this comment.
entry count cannot be 0, but then have 1 entry...
brandonocasey
commented
Dec 18, 2020
| @@ -243,7 +243,7 @@ module.exports.sampleMoov = | |||
| box('stsd', | |||
| 0x01, // version 1 | |||
| 0x00, 0x00, 0x00, // flags | |||
| 0x00, 0x00, 0x00, 0x00, // entry_count | |||
| 0x00, 0x00, 0x00, 0x01, // entry_count | |||
brandonocasey
force-pushed
the
feat/vhs-utils
branch
2 times, most recently
from
8bbb236 to
65e8d8b
Compare
brandonocasey
force-pushed
the
feat/vhs-utils
branch
from
65e8d8b to
4c9dc2d
Compare
|
This is blocked until we have enough time to get to everything in #362 |
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.