Fix silence insertion to not insert extra frames when audio is offset… #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbcmdth
reviewed
Mar 1, 2017
lib/mp4/transmuxer.js
Outdated
| // determine frame clock duration based on sample rate, round up to avoid overfills | ||
| frameDuration = Math.ceil(ONE_SECOND_IN_TS / (track.samplerate / 1024)); | ||
| // gap is at least a frame duration | ||
| baseMediaDecodeTimeTs - audioAppendStartTs >= frameDuration) { |
There was a problem hiding this comment.
I feel like this condition should be:
baseMediaDecodeTimeTs - Math.max(audioAppendStartTs, videoBaseMediaDecodeTime) >= frameDuration
...but if that is the case then we can just remove the condition completely since it'll be calculated below and, if this were to evaluate to false, would result in a value that is audioFillFrameCount < 1 and we will exit early.
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… from video