-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sidx information to segment base playlists #41
Conversation
Requires #43 (merged) |
dbfd278
to
d8fe320
Compare
9d393bb
to
3543986
Compare
This appears to be working to some degree. Will do more testing next week. |
f48bb8d
to
f46399e
Compare
This stream fails: http://yt-dash-mse-test.commondatastorage.googleapis.com/media/car-20120827-manifest.mpd, from http://dash-mse-test.appspot.com/media.html |
So, the youtube car stream has something that is potentially against the spec, it has two representations with the same id. Both Shaka and Youtube test player work. Realized that if I do a null check they work fine. Also, the two comments above should've been in the VHS repo. |
I think the null check makes sense since the https://github.com/videojs/mpd-parser/pull/41/files#diff-09d49417dae2795e5eab7a01f6db04daR56 Though I'm surprised I didn't run into it earlier |
Attempted fix for videojs/http-streaming#162.
Status
This appears to be working on the issue source.
Changes proposed:
sidxMapping
option on theparse
method to allow modifying a complete master playlist with metadata from a parsed sidx boxsidx
property with byteRange references to manifest objects generated with SegmentBase. This applies to both video and audio playlistssidx.references
when thesidxMapping
option is givenSources
To do