fix: fixed segment timeline parsing when duration is present #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldayananda
reviewed
Oct 11, 2018
src/inheritAttributes.js
Outdated
|
|
||
| if (periodAtt.duration) { | ||
| periodAttributes.periodDuration = periodAtt.duration; | ||
| } |
There was a problem hiding this comment.
Looks like we're losing the rest of the periodAtt, which I don't think we intended
There was a problem hiding this comment.
This is intended, I'd rather pass along attributes that will be used. That's what caused the bug initially since Period@duration and AdaptationSet@duration have the same name but mean different things.
There was a problem hiding this comment.
I guess I meant if there's some other attribute that should be merged to topLevel. As an alternative, we could prepend the period attributes with period
There was a problem hiding this comment.
At the moment we actually don't even use Period@duration so I could remove this part entirely.
ldayananda
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes videojs/http-streaming#253