feat: parse key attributes for Widevine HLS #88
Conversation
| @@ -49,6 +50,7 @@ export default class Parser extends Stream { | |||
| 'CLOSED-CAPTIONS': {}, | |||
| 'SUBTITLES': {} | |||
| }; | |||
| const widevineUuid = 'urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed'; | |||
There was a problem hiding this comment.
I know nothing about this really, but is this a universally valid UUID?
Answered my own question.
| @@ -49,6 +50,7 @@ export default class Parser extends Stream { | |||
| 'CLOSED-CAPTIONS': {}, | |||
| 'SUBTITLES': {} | |||
| }; | |||
| const widevineUuid = 'urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed'; | |||
There was a problem hiding this comment.
Yeah, I had the same question. It's in the spec doc... 🤷♂
There was a problem hiding this comment.
Yep, and the same string is used for mpds (see mpd-parser)
There was a problem hiding this comment.
Might be useful to add a comment and link to the widevine hls extension spec
| return; | ||
| } | ||
|
|
||
| if (entry.attributes.METHOD === 'SAMPLE-AES-CENC') { |
There was a problem hiding this comment.
This case is fine just deprecated?
Maybe we should group the ones that exit early?
There was a problem hiding this comment.
Just logging a warning should be fine. The spec didn't replace 'SAMPLE-AES-CENC' with 'SAMPLE-AES-CTR' all that long ago so there's likely still a good amount of content out there using the former. I could group the early exits together, but that would require separating the two METHOD validation blocks. I don't feel strongly either way.
|
|
||
| // if Widevine key attributes are valid, store them as `contentProtection` | ||
| // on the manifest to emulate Widevine tag structure in a DASH mpd | ||
| this.manifest.contentProtection = { |
There was a problem hiding this comment.
should we call this out specifically as widevine since it isn't standard hls?
There was a problem hiding this comment.
I guess the mpd parser calls it this as well?
There was a problem hiding this comment.
You mean renaming contentProtection to widevine? We could, but that would require an additional change in VHS (and perhaps elsewhere), which already expects contentProtection. Calling it contentProtection maintains greater parity with mpd-parser.
|
Verified manually. |
This adds parsing of
EXT-X-KEYattributes for Widevine support, as outlined in this spec