EXT-X-START tag support #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Nov 20, 2017
src/parse-stream.js
Outdated
| if (match[1]) { | ||
| event.attributes = parseAttributes(match[1]); | ||
|
|
||
| event.attributes['TIME-OFFSET'] = parseFloat(event.attributes['TIME-OFFSET'], 10); |
There was a problem hiding this comment.
Does parseFloat take a second parameter?
There was a problem hiding this comment.
I don't believe it does - sorry about that, I'm used to parseInt taking a base parameter and just assumed parseFloat behaved similarly...
| }); | ||
| parser.push(manifest); | ||
|
|
||
| assert.ok(warning, 'a warning was triggered'); |
There was a problem hiding this comment.
Minor, but might be worth testing the warning message.
gesinger
approved these changes
Nov 20, 2017
forbesjo
approved these changes
Nov 20, 2017
|
Tested locally and tests pass after working around rollup issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should add support for the EXT-X-START tag and its two attributes.