Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add program-date-time tag info to parsed segments #27

Merged
merged 2 commits into from
Feb 23, 2018
Merged

add program-date-time tag info to parsed segments #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74447f5
add program-date-time tag info to parsed segments
mjneil Jul 5, 2017
cbb3762
update comment
mjneil Oct 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,16 @@ export default class Parser extends Stream {
this.manifest.discontinuityStarts.push(uris.length);
},
'program-date-time'() {
this.manifest.dateTimeString = entry.dateTimeString;
this.manifest.dateTimeObject = entry.dateTimeObject;
if (typeof this.manifest.dateTimeString === 'undefined') {
// PROGRAM-DATE-TIME is a media-segment tag, but for backwards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a TODO notice for the next major version to remove this

// compatibility, we add the first occurance of the PROGRAM-DATE-TIME tag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

occurence

// to the manifest object
this.manifest.dateTimeString = entry.dateTimeString;
this.manifest.dateTimeObject = entry.dateTimeObject;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for calculating stream time from currentTime, so is more important than "for backwards compatibility" implies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could still calculate stream time from currentTime by looking at the dateTimeString attached to the individual segment objects, the backwards compatibility is so updating to a version including this change wont break code that is expecting that information to be on the playlist object


currentUri.dateTimeString = entry.dateTimeString;
currentUri.dateTimeObject = entry.dateTimeObject;
},
targetduration() {
if (!isFinite(entry.duration) || entry.duration < 0) {
Expand Down
9 changes: 9 additions & 0 deletions test/fixtures/m3u8/dateTime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@
"playlistType": "VOD",
"segments": [
{
"dateTimeString": "2016-06-22T09:20:16.166-04:00",
"dateTimeObject": new Date("2016-06-22T09:20:16.166-04:00"),
"duration": 10,
"timeline": 0,
"uri": "hls_450k_video.ts"
},
{
"dateTimeString": "2016-06-22T09:20:26.166-04:00",
"dateTimeObject": new Date("2016-06-22T09:20:26.166-04:00"),
"duration": 10,
"timeline": 0,
"uri": "hls_450k_video.ts"
Expand Down
5 changes: 4 additions & 1 deletion test/fixtures/m3u8/dateTime.m3u8
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
#EXTM3U
#EXT-X-PLAYLIST-TYPE:VOD
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-PROGRAM-DATE-TIME:2016-06-22T09:20:16.166-04:00
#EXT-X-ALLOW-CACHE:NO
#EXT-X-TARGETDURATION:10
#EXT-X-PROGRAM-DATE-TIME:2016-06-22T09:20:16.166-04:00
#EXTINF:10
hls_450k_video.ts
#EXT-X-PROGRAM-DATE-TIME:2016-06-22T09:20:26.166-04:00
#EXTINF:10
hls_450k_video.ts
#EXT-X-ENDLIST