feat: improve parsing for a frame-rate attribute #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is related to this videojs/mpd-parser#159 |
|
This looks good @gjanblaszczyk , thank you. The only concern I have is that it technically breaks the old output. Although it should be minor, and is more appropriate as a number, we should consider a small major for this. |
|
Yeah, technically a breaking change. Don't see a problem with making a major version of m3u8-parser, though. |
gkatsev
approved these changes
Jul 28, 2022
gesinger
approved these changes
Jul 28, 2022
|
@gkatsev Is it enough to add this footer message during GitHub squash and merge action? or maybe I should do something more... |
|
yup, that would do it. I rarely if ever merge locally anymore and we prefer squash+merge in the video.js projects. |
gkatsev
pushed a commit
that referenced
this pull request
Aug 2, 2022
BREAKING CHANGE: parser changes an output type for 'FRAME-RATE' attribute from a string to a number.
ryancase
added a commit
to TransmitLive/m3u8-parser
that referenced
this pull request
Apr 23, 2024
This reverts commit d51e93f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'FRAME-RATE' attribute should be a floating-point number type rather than a string.