feat: Add llhls preloadSegment, add parts to segments, and fix byterange for parts/preloadHints #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Feb 5, 2021
| @@ -5,6 +5,21 @@ import Stream from '@videojs/vhs-utils/es/stream.js'; | |||
|
|
|||
| const TAB = String.fromCharCode(0x09); | |||
|
|
|||
| const parseByterange = function(byterangeString) { | |||
There was a problem hiding this comment.
Moved all byterange parsing into here as we do this for map, byterange, and part
brandonocasey
commented
Feb 5, 2021
| @@ -535,6 +543,11 @@ export default class ParseStream extends Stream { | |||
| ['BYTERANGE-START', 'BYTERANGE-LENGTH'].forEach(function(key) { | |||
| if (event.attributes.hasOwnProperty(key)) { | |||
| event.attributes[key] = parseInt(event.attributes[key], 10); | |||
|
|
|||
| const subkey = key === 'BYTERANGE-LENGTH' ? 'length' : 'offset'; | |||
There was a problem hiding this comment.
This one is a bit different as we have attributes for both offest and length
brandonocasey
commented
Feb 5, 2021
| @@ -92,6 +92,7 @@ export default class Parser extends Stream { | |||
| let currentMap; | |||
| // if specified, the active decryption key | |||
| let key; | |||
| let hasParts = false; | |||
There was a problem hiding this comment.
Added this to keep renditionReport warnings firing if we get a rendition report before any parts.
brandonocasey
commented
Feb 5, 2021
| currentUri.timeline = currentTimeline; | ||
| } | ||
|
|
||
| this.manifest.preloadSegment = currentUri; |
There was a problem hiding this comment.
build preload segment if we get end without getting an actual segment uri.
brandonocasey
commented
Feb 5, 2021
| @@ -115,6 +116,29 @@ export default class Parser extends Stream { | |||
| // to provide the offset, in which case it defaults to the next byte after the | |||
| // previous segment | |||
| let lastByterangeEnd = 0; | |||
| // keep track of the last seen part's byte range end. | |||
| let lastPartByterangeEnd = 0; | |||
There was a problem hiding this comment.
keep track of the current part byterange
brandonocasey
changed the title
gesinger
reviewed
Feb 23, 2021
|
gkatsev
reviewed
Mar 1, 2021
|
good call on the byterange stuff @gkatsev I think I got locked in on making the code look similar to what it used to and didn't simplify enough. |
gkatsev
approved these changes
Mar 2, 2021
gesinger
reviewed
Mar 4, 2021
Co-authored-by: Garrett Singer <[email protected]>
gesinger
approved these changes
Mar 4, 2021
miadabdi
pushed a commit
to miadabdi/m3u8-parser
that referenced
this pull request
Jul 21, 2021
…ts, unify byterange handling (videojs#137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a few things: