feat: add version parsing and remove totalduration #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
feat/version-totalduration
branch
from
0427fb8 to
649345d
Compare
gkatsev
approved these changes
Jan 22, 2021
| @@ -354,15 +359,6 @@ export default class Parser extends Stream { | |||
| } | |||
| this.manifest.targetDuration = entry.duration; | |||
| }, | |||
| totalduration() { | |||
There was a problem hiding this comment.
this was probably for #ZEN-TOTAL-DURATION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never used the
#EXT-X-VERSIONeven though we parsed it.totaldurationdoesn't exist in parse-stream and there isn't anything equivalent in the spec.