add program-date-time tag info to parsed segments #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
reviewed
Jul 17, 2017
src/parser.js
Outdated
| // to the manifest object | ||
| this.manifest.dateTimeString = entry.dateTimeString; | ||
| this.manifest.dateTimeObject = entry.dateTimeObject; | ||
| } |
There was a problem hiding this comment.
This is needed for calculating stream time from currentTime, so is more important than "for backwards compatibility" implies.
There was a problem hiding this comment.
You could still calculate stream time from currentTime by looking at the dateTimeString attached to the individual segment objects, the backwards compatibility is so updating to a version including this change wont break code that is expecting that information to be on the playlist object
gesinger
reviewed
Sep 11, 2017
src/parser.js
Outdated
| this.manifest.dateTimeObject = entry.dateTimeObject; | ||
| if (typeof this.manifest.dateTimeString === 'undefined') { | ||
| // PROGRAM-DATE-TIME is a media-segment tag, but for backwards | ||
| // compatibility, we add the first occurance of the PROGRAM-DATE-TIME tag |
| this.manifest.dateTimeString = entry.dateTimeString; | ||
| this.manifest.dateTimeObject = entry.dateTimeObject; | ||
| if (typeof this.manifest.dateTimeString === 'undefined') { | ||
| // PROGRAM-DATE-TIME is a media-segment tag, but for backwards |
There was a problem hiding this comment.
We should add a TODO notice for the next major version to remove this
gesinger
approved these changes
Nov 13, 2017
mjneil
added a commit
that referenced
this pull request
Feb 23, 2018
miadabdi
pushed a commit
to miadabdi/m3u8-parser
that referenced
this pull request
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26
This adds program date time info onto the parsed segment objects as well as the manifest since it is meant to be a segment tag