fix: have reloadSourceOnError get src from player #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were getting the source from tech.currentSource_. This only gets set when a source handler like VHS is used. However, because VHS is in Video.js by default and the plugin is global, some people are using this plugin for other sources as well. There isn't a reason why we should be relying on tech.currentSource_ over player.currentSource() when we have access to the player in the plugin. Fixes videojs/video.js#6744
gesinger
reviewed
Jul 8, 2020
Co-authored-by: Garrett Singer <[email protected]>
gesinger
approved these changes
Jul 8, 2020
|
@gkatsev Do I understand correctly that You fixed this? If so, when will the new version of the player be released and will there be documentation for the parameter |
|
@Raino it's fixed. It may be a bit to get released as it's tied with a lot of other changes. In the meantime, you could grab the code from https://github.com/videojs/http-streaming/blob/main/src/reload-source-on-error.js and load it manually. |
|
@gkatsev How can I install this on my site? Perhaps I can download a full archive of all the scripts with the latest changes somewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were getting the source from tech.currentSource_. This
only gets set when a source handler like VHS is used. However, because
VHS is in Video.js by default and the plugin is global, some people are
using this plugin for other sources as well.
There isn't a reason why we should be relying on tech.currentSource_
over player.currentSource() when we have access to the player in the
plugin.
Fixes videojs/video.js#6744