-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: suggestedPresentationDelay #698
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ae035eb
relative d3
gkatsev fdcd80f
suggestedPresentationDelay
gkatsev dc878ee
move SPD down in MPC
gkatsev 32c26f3
add jsdocs and rename suggestedPresentationDelay to liveEdgePadding i…
gkatsev ce220ad
wrap in parens for clarity
gkatsev 7a82634
fixup tests
gkatsev 7b49304
add safeLiveIndex with liveEdgePadding test
gkatsev 597d7f5
update tests for liveEdgePadding
gkatsev 5183ebe
special-case liveEdgePadding
gkatsev 1027e61
better combined algorithm thanks to @mjneil
gkatsev e4d3353
mark liveEdgePadding as optional
gkatsev 70a4c40
remove is
gkatsev ad0908a
Revert "remove is"
gkatsev 4c2cdb5
remove is
gkatsev b72173d
add whitespace
gkatsev 257718f
use empty object for master placeholder
gkatsev 52bf952
update tests
gkatsev def00e0
update to mpd-parser 0.10.0 which includes support for suggestedPrese…
gkatsev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this to account for any distance less than last segment duration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, I think we should only special-case 0 exactly. Any other value should be ran through the loop below to find the appropriate return value.