feat: setup EME key systems for HLS as well as DASH (#629) #657
Conversation
| * @return {Boolean} if this is an audio codec | ||
| * @private | ||
| */ | ||
| export const isAudioCodec = function(codec) { |
There was a problem hiding this comment.
brought these back from 1.x
There was a problem hiding this comment.
not as part of this PR, but may make sense to move this into vhs-utils.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
I may be missing something in the chain here, but:
setupEmeOptions is called on selectedinitialmedia from masterPlaylistController
but
sourceUpdater's createSourceBuffers (which sets the codecs property) isn't called until trackinfo or handleSourceOpen, both of which require startingMedia_ to be set on the mainSegmentLoader, which is set on handleTrackInfo_, which only comes on handling of segment data.
Given that, would sourceUpdater's codecs property be set at this point?
|
You're right, |
brandonocasey
force-pushed
the
feat/setup-eme-for-hls
branch
from
7e825dc to
5ce23a7
Compare
brandonocasey
force-pushed
the
feat/setup-eme-for-hls
branch
3 times, most recently
from
fabb1ef to
65b637c
Compare
brandonocasey
force-pushed
the
feat/setup-eme-for-hls
branch
from
65b637c to
8bcd942
Compare
Description
#629 but for master!