fix: Correctly use videoSegmentTimingInfo from the transmuxer #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Jul 16, 2019
brandonocasey
force-pushed
the
fix/video-segment-timing-info
branch
2 times, most recently
from
65ce4d0 to
1c84622
Compare
brandonocasey
commented
Jul 16, 2019
| @@ -6,7 +6,7 @@ import SourceUpdater from '../src/source-updater'; | |||
| import {mp4VideoInit, mp4AudioInit, mp4Video, mp4Audio} from './dist/test-segments'; | |||
| import { timeRangesEqual } from './custom-assertions.js'; | |||
|
|
|||
| const checkIntialDuration = function({duration}) { | |||
| const checkInitialDuration = function({duration}) { | |||
brandonocasey
force-pushed
the
fix/video-segment-timing-info
branch
2 times, most recently
from
928f63b to
4b91de1
Compare
brandonocasey
force-pushed
the
fix/video-segment-timing-info
branch
from
bf6f9c5 to
29c4ccc
Compare
brandonocasey
force-pushed
the
fix/video-segment-timing-info
branch
from
29c4ccc to
1929142
Compare
gkatsev
reviewed
Aug 1, 2019
gkatsev
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This must have happened sometime during the merging of tba/lhls and #371
Seems like we were expecting the native
SourceBufferto firevideoSegmentTimingInfowhich won't happen because we were firing it inVirtualSourceBufferwhen the transmuxer fired it. Now we simply pass callbacks tomediaSegmentRequestfor functions that we want to handle from the transmuxer.