fix: change rollup config so that npm run watch works #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was annoyed with
npm run watch
not working properly, so I decided to try to fix it. I don't know if this is the right approach, but I did what video.js is doing with adding modules into theexternal
config key.With this + videojs/video.js#5966, you can change a file in VHS and it will be compiled into video.js. It takes a bit to compile, but I found that I would sometimes get some weird behaviour if I was loading both
video.js
andvideojs-http-streaming.js
.Specific Changes proposed
Added the modules that caused compilation failure to the
external
config key for CommonJS and ES output.Requirements Checklist