Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change rollup config so that npm run watch works #484

Merged
merged 1 commit into from
May 2, 2019

Conversation

squarebracket
Copy link
Contributor

Description

I was annoyed with npm run watch not working properly, so I decided to try to fix it. I don't know if this is the right approach, but I did what video.js is doing with adding modules into the external config key.

With this + videojs/video.js#5966, you can change a file in VHS and it will be compiled into video.js. It takes a bit to compile, but I found that I would sometimes get some weird behaviour if I was loading both video.js and videojs-http-streaming.js.

Specific Changes proposed

Added the modules that caused compilation failure to the external config key for CommonJS and ES output.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@brandonocasey
Copy link
Contributor

brandonocasey commented May 2, 2019

Going to give this a quick test, but I think this is the correct approach

EDIT: It works!

@brandonocasey brandonocasey merged commit ad6f292 into videojs:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants